[AG-1557] Fixes ModelAD File size must be at least one byte Error
#150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thomasyu888
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
With recent changes made in ADT adding support for ModelAD data processing, we encountered an error in processing when using the
platformflag. This is caused because despite the fact that there is no GX data validation to run for ModelAD at the moment, the ADTGXReporter was still trying to update the GX report table. This caused an empty list of records to be passed tosyn.storehere, causing the reported error.Solution:
I added an additional condition to
ADTGXReporter.update_tableso that the update attempt is not made if there are no new records to update in the first place.Notes:
adt --helpcommand to learn how to use the package.