MG45 - ADT: Pathology data ETL #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 4, 2024 10:57
…D_general_transform change
beatrizsaldana
requested review from
BWMac,
BryanFauble,
JessterB and
jaclynbeck-sage
beatrizsaldana
commented
Oct 4, 2024
BWMac
reviewed
Oct 4, 2024
jaclynbeck-sage
requested changes
Oct 7, 2024
|
beatrizsaldana
deleted the
beatrizsaldana/MG-45/ADT-Pathology-data-ETL-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding pathology dataset to the set of transforms.
See Jira ticket for more information
The
pathologyandbiomarkersdatasets have the same fundamental input and output structure and require the same transform. Instead of duplicating code, the existing transform for thebiomarkersdataset was generalized to allow it to be used by thepathologydataset. All related tests were also generalized but were not functionally changed.Changes
pathologydataset was added tomodelad_test_config.yaml.pathologydataset was added toprocess.py.biomarkers_transformfunction was renamed tomodelAD_general_transform.modelAD_general_transformto allow multiple datasets to use it.