Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-954] Adds proteomics_srm GX Suite #145

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jul 19, 2024

Description:

This PR implements a GX expectation suite for the proteomics_srm dataset.

I used the rules here and here as reference.

An example report file can be viewed here.

@BWMac BWMac marked this pull request as ready for review July 19, 2024 16:15
Copy link
Contributor

@jaclynbeck-sage jaclynbeck-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just waiting on resolution of uniqid regex from other PR.

@BWMac BWMac requested a review from jaclynbeck-sage July 23, 2024 16:29
Copy link

sonarcloud bot commented Jul 23, 2024

@BWMac
Copy link
Contributor Author

BWMac commented Jul 23, 2024

@JessterB @jaclynbeck-sage I applied the regex strings discussed in the proteomics PR and no records failed so I think this one is ready for another look!

Copy link
Contributor

@jaclynbeck-sage jaclynbeck-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Thanks for the GX work!

@BWMac BWMac requested a review from JessterB September 16, 2024 17:48
Copy link

sonarcloud bot commented Sep 18, 2024

Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ship it!

@BWMac BWMac merged commit 86b5f29 into dev Sep 24, 2024
9 checks passed
@BWMac BWMac deleted the bwmac/IBCDPE-954/proteomics_srm branch September 24, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants