Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IBCDPE-794] Adds proteomics GX Suite #143

Merged
merged 8 commits into from
Sep 24, 2024
Merged

[IBCDPE-794] Adds proteomics GX Suite #143

merged 8 commits into from
Sep 24, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jul 18, 2024 •
edited
Loading

Description:

This PR implements a GX expectation suite for the proteomics dataset.

I used the rules here and here as reference.

An example report file can be viewed here.

@BWMac BWMac marked this pull request as ready for review July 18, 2024 17:10
@BWMac BWMac requested a review from jaclynbeck-sage July 19, 2024 15:38
@BWMac BWMac requested a review from jaclynbeck-sage July 23, 2024 16:29
JessterB
JessterB reviewed Jul 23, 2024
View reviewed changes
gx_suite_definitions/proteomics.ipynb Outdated Show resolved Hide resolved
gx_suite_definitions/proteomics.ipynb Show resolved Hide resolved
gx_suite_definitions/proteomics.ipynb Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BWMac BWMac mentioned this pull request Jul 23, 2024
Merged
JessterB
JessterB approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be good to merge this, as Jaclyn has introduced a custom transform that filters out rows with invalid uniqid values.

thomasyu888
thomasyu888 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Thanks for the great work here!

jaclynbeck-sage
jaclynbeck-sage approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@jaclynbeck-sage jaclynbeck-sage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! May I suggest pulling the recent changes from dev into this branch and testing that the GX passes now?

JessterB
JessterB requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments about the regexes on the other PR

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BWMac BWMac requested a review from JessterB September 18, 2024 17:44
JessterB
JessterB approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@BWMac BWMac merged commit e90c363 into dev Sep 24, 2024
9 checks passed
@BWMac BWMac deleted the bwmac/IBCDPE-794/proteomics_gx branch September 24, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaclynbeck-sage jaclynbeck-sage jaclynbeck-sage approved these changes

@JessterB JessterB JessterB approved these changes

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BWMac @thomasyu888 @JessterB @jaclynbeck-sage