Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-796] Adds rnaseq_differential_expression expectation suite #136

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jun 10, 2024

Description:

This PR implements a GX expectation suite for the rnaseq_differential_expression dataset.

Please let me know if there are any additional expectations I should add, or if there are any adjustments to be made to the expectations I have already implemented.

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BWMac BWMac marked this pull request as ready for review June 10, 2024 21:40
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM! I'll let other weigh in on correctness of the checks

Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checks look good!

@BWMac BWMac merged commit 6ccc761 into dev Jun 11, 2024
9 checks passed
@BWMac BWMac deleted the bwmac/IBCDPE-796/rna_de_expectation_suite branch June 11, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants