Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test for empty tables for the method Table.sort_rows #431

Merged

Conversation

robmeth
Copy link
Contributor

@robmeth robmeth commented Jul 7, 2023

Closes #402

Summary of Changes

implement the test for empty table in the tests for non empty tables.

@robmeth robmeth requested a review from a team as a code owner July 7, 2023 08:14
@robmeth robmeth linked an issue Jul 7, 2023 that may be closed by this pull request
@robmeth robmeth marked this pull request as draft July 7, 2023 08:16
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 0 0 0.47s
✅ PYTHON mypy 1 0 1.33s
✅ PYTHON ruff 1 0 0 0.1s
✅ REPOSITORY git_diff yes no 0.09s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@robmeth robmeth changed the title feat: add test for empty tables feat: add test for empty tables for the method Table.sort_rows Jul 7, 2023
@robmeth robmeth marked this pull request as ready for review July 7, 2023 08:21
Copy link
Contributor

@jxnior01 jxnior01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me :=)

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #431 (fcbf3e7) into main (5e3da8d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #431   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2428      2428           
=========================================
  Hits          2428      2428           

@robmeth robmeth merged commit f94b768 into main Jul 7, 2023
@robmeth robmeth deleted the 402-change-test-for-empty-table-for-the-method-tablesort_rows branch July 7, 2023 09:59
lars-reimann pushed a commit that referenced this pull request Jul 13, 2023
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13)

### Features

* Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275)
* add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381)
* add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127)
* add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402)
* added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380)
* added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349)
* discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143)
* Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150)
* Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58)
* new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262)
* rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439)
* suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203)

### Bug Fixes

* added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362)
* don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5))
* Warnings raised by underlying seaborn and numpy libraries  ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change test for empty table for the method Table.sort_rows
4 participants