-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Introduce Abstract Base Class Model
and add fit
and predict
methods to Table
#352
Comments
Model
ABC and allow for double dispatchModel
and allow for double dispatch
Model
and allow for double dispatchModel
and add fit
and predict
methods to Table
So far, this superclass is something I've deliberately avoided since I don't see much use in it.
Overall, I think this proposal pollutes the data containers too much. Moreover, it introduces a cyclic dependency between the Because of this, I'd strongly vote against
I also don't like This leaves a potential |
Superseded by #377. |
Is your feature request related to a problem?
Transformer
s, we have both atransform
method in theTransformer
class as well as atransform_table
in theTable
class. For the (models' and transformers')fit
methods, there is no such method inside theTable
class.Classifier
s andRegressor
s share API design and conceptual functionality, but there is no suitable common super type that allows for uniform handling.Desired solution
Introduce new class
Model
as parent class forClassifier
andRegressor
.Introduce methods:
fit_model(Model)
toTable
classfit_transformer(Transformer)
toTable
classpredict(Model)
toTable
class(Analogous to
transform_table
method inTable
class.)Override these appropriately in
TaggedTable
(see #58).The text was updated successfully, but these errors were encountered: