-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rename fit_transform
to fit_and_transform
#119
Conversation
Codecov Report
@@ Coverage Diff @@
## main #119 +/- ##
=======================================
Coverage 93.08% 93.08%
=======================================
Files 36 36
Lines 1258 1258
=======================================
Hits 1171 1171
Misses 87 87
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fit_transform
to fix_and_transform
fit_transform
to fix_and_transform
fit_transform
to fix_and_transform
fit_transform
to fix_and_transform
fit_transform
to fix_and_transform
@gantanikhilraj Please leave the title with |
Ok @lars-reimann . |
fit_transform
to fix_and_transform
fit_transform
to fit_and_transform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks! I've just shortened the PR description a bit so it focuses more on the user-facing impact and renamed the test classes that correspond to the method.
## [0.8.0](v0.7.0...v0.8.0) (2023-03-31) ### Features * create empty `Table` without schema ([#128](#128)) ([ddd3f59](ddd3f59)), closes [#127](#127) * improve `ColumnType`s ([#132](#132)) ([1786a87](1786a87)), closes [#113](#113) * infer schema of row if not passed explicitly ([#134](#134)) ([c5869bb](c5869bb)), closes [#15](#15) * new method `is_fitted` to check whether a model is fitted ([#130](#130)) ([8e1c3ea](8e1c3ea)) * new method `is_fitted` to check whether a transformer is fitted ([#131](#131)) ([e20954f](e20954f)) * rename `drop_XY` methods of `Table` to `remove_XY` ([#122](#122)) ([98d76a4](98d76a4)) * rename `fit_transform` to `fit_and_transform` ([#119](#119)) ([76a7112](76a7112)), closes [#112](#112) * rename `shuffle` to `shuffle_rows` ([#125](#125)) ([ea21928](ea21928)) * rename `slice` to `slice_rows` ([#126](#126)) ([20d21c2](20d21c2)) * rename `TableSchema` to `Schema` ([#133](#133)) ([1419d25](1419d25))
🎉 This PR is included in version 0.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Closes #112.
Summary of Changes
Rename
fit_transform
tofit_and_transform
to better indicate that this method combines the two stepsfit
andtransform
.