Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select path for runner when installing #1238

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Sep 25, 2024

Closes #1144

Summary of Changes

Users must now select a path for the runner during installation, since the path given by VS Code might not be writable.

Copy link

github-actions bot commented Sep 25, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.14s
✅ TYPESCRIPT eslint 3 0 0 4.62s
✅ TYPESCRIPT prettier 3 0 0 0.82s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (77ad26c) to head (d2fde7f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1238   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         110      110           
  Lines       19247    19247           
  Branches     4110     4110           
=======================================
  Hits        19207    19207           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann merged commit 3d9d4db into main Sep 25, 2024
7 checks passed
@lars-reimann lars-reimann deleted the installer-choose-path branch September 25, 2024 15:32
lars-reimann pushed a commit that referenced this pull request Sep 25, 2024
## [0.18.0](v0.17.0...v0.18.0) (2024-09-25)

### Features

* eda history basic setup ([#1212](#1212)) ([597672b](597672b)), closes [#1211](#1211)
* eda refresh outdated view ([#1215](#1215)) ([2295d80](2295d80)), closes [#1214](#1214)
* **eda:** filter by column ([#1217](#1217)) ([77ad26c](77ad26c)), closes [#1216](#1216)
* integrate version 0.28.0 of the `safe-ds` Python library ([#1237](#1237)) ([1b742e7](1b742e7))
* select path for runner when installing ([#1238](#1238)) ([3d9d4db](3d9d4db)), closes [#1144](#1144)

### Bug Fixes

* eda table right click improvements ([#1213](#1213)) ([cf440e3](cf440e3)), closes [#1180](#1180)
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runner installer not working on MacOS
1 participant