Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sort rows in EDA #1183

Merged
merged 40 commits into from
May 29, 2024
Merged

feat: sort rows in EDA #1183

merged 40 commits into from
May 29, 2024

Conversation

SmiteDeluxe
Copy link
Contributor

Closes #1151

Summary of Changes

  • History has overrideId prop on entries now and RunnerAPI only keeps last entry of each overrideId, allowing overriding sorts, voiding of sorts and in general execution of only the relevant needed entries once history is fully implemented
  • Thus sorting working incl. visual feedback & loading screen if > 500ms load & preserving of relevant state on Table update & removing of sort by clicking active sort again
  • All of pastEntries execution in correct order, with only relevant entries & correct passing on of placeholders

SmiteDeluxe and others added 30 commits May 14, 2024 18:52
@SmiteDeluxe
feat: clean up state and separate it
8a36f5c
@SmiteDeluxe
Merge branch '1169-improve-eda-state' into 1171-hide-column-feature-i…
54ef0a3 
…n-eda
@SmiteDeluxe
feat: hidden columns messaging logic for vis vs. manip
4d8bf10
@SmiteDeluxe
feat: hide columns functionality
79f0aa0
@SmiteDeluxe
feat: making other tabs outdated on relevant changes in history
e98549c
@SmiteDeluxe
fix: improv oudated logic & display
f79923a
@SmiteDeluxe
fix: better hidden col handling for not 'none' col count tabs
2254cf1
@SmiteDeluxe
fix: slightly smaller active tab font
6c8cbea
@SmiteDeluxe
Merge remote-tracking branch 'origin/main' into 1171-hide-column-feat…
6c4de29 
…ure-in-eda
@SmiteDeluxe
fix: only numerical columns in plots other than histogram
0df827f
@SmiteDeluxe
fix: order and fix up col right clicks
4ff5cc0
@SmiteDeluxe
fix: buildATab NonNumerical based changes
573aee7
@SmiteDeluxe
feat: footer basics for col count
2d2810b
@SmiteDeluxe
fix: hidden cols excl. in profiling errors
fb1dcba
@SmiteDeluxe
fix: profiling error store
f66aa3b
@SmiteDeluxe
feat: right click on profiling possible
3b5c772
@SmiteDeluxe
feat: hidden col menu to show
cec02ab
@SmiteDeluxe
refactor: rename color vars
5049fd7
@SmiteDeluxe
fix: z-index of col show menu & fix: reactivity sidebar width changes
03bdd3e
@SmiteDeluxe
fix: only right click interaction allowed on hidden col & styling fixes
c2d96d3
@SmiteDeluxe
fix: hiddenCol reorder drag over & resize min width
01679cc
@SmiteDeluxe
refactor
67d65de
@SmiteDeluxe
fix: bug
73844a7
@megalinter-bot
style: apply automated linter fixes
4b448f7
@SmiteDeluxe
Merge branch '1171-hide-column-feature-in-eda' into 1151-sort-rows-in…
a78ebc6 
…-eda-tool
@SmiteDeluxe
feat: sort hover effect
46aaf2c
@SmiteDeluxe
Merge remote-tracking branch 'origin/main' into 1171-hide-column-feat…
2b88eab 
…ure-in-eda
@SmiteDeluxe
Merge remote-tracking branch 'origin/main' into 1151-sort-rows-in-eda…
aa791bf 
…-tool
@SmiteDeluxe
feat: sort columns & fixed pastEntry execution
4eca383
@SmiteDeluxe
feat: overrideIds for history entries
7921990
@SmiteDeluxe SmiteDeluxe added enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels May 29, 2024
@SmiteDeluxe SmiteDeluxe requested a review from lars-reimann as a code owner May 29, 2024 12:31
@SmiteDeluxe SmiteDeluxe linked an issue May 29, 2024 that may be closed by this pull request
Sort rows in EDA tool #1151
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CSS stylelint 1 0 0 1.61s
✅ JSON prettier 5 0 0 2.42s
✅ REPOSITORY git_diff yes no 0.11s
✅ TSX eslint 4 0 0 7.84s
✅ TYPESCRIPT eslint 4 0 0 7.1s
✅ TYPESCRIPT prettier 4 0 0 1.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@SmiteDeluxe
Copy link
Contributor Author

This ideally is merged after #1181 as it includes commits from there by having merged the hide columns branch into this branch at the start.

@codecov Codecov
Copy link

codecov bot commented May 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.79%. Comparing base (e79de17) to head (54a1bf9).
Report is 37 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1183   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files         110      110           
  Lines       19243    19243           
  Branches     4109     4109           
=======================================
  Hits        19203    19203           
  Misses         40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SmiteDeluxe SmiteDeluxe mentioned this pull request May 29, 2024
Merged
lars-reimann
lars-reimann approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Very nice addition, thanks!

@lars-reimann lars-reimann merged commit ddd5186 into main May 29, 2024
7 checks passed
@lars-reimann lars-reimann deleted the 1151-sort-rows-in-eda-tool branch May 29, 2024 16:25
lars-reimann pushed a commit that referenced this pull request May 29, 2024
@semantic-release-bot
chore(release): 0.17.0 [skip ci]
4c93458 
## [0.17.0](v0.16.1...v0.17.0) (2024-05-29)

### Features

* hide columns in EDA ([#1181](#1181)) ([15ccaac](15ccaac)), closes [#1171](#1171)
* infer column type using runner ([#1182](#1182)) ([846f404](846f404)), closes [#994](#994)
* integrate version 0.26.0 of the `safe-ds` Python library ([#1184](#1184)) ([e79de17](e79de17))
* show symbol types in headings and table of contents ([#1178](#1178)) ([b2f0966](b2f0966)), closes [#1164](#1164)
* sort rows in EDA ([#1183](#1183)) ([ddd5186](ddd5186)), closes [#1151](#1151)
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

Assignees
No one assigned
Labels
enhancement 💡 New feature or request released Included in a release vscode 🔨 Issues regarding tools like the VS Code extension
Projects
DSL
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort rows in EDA tool
3 participants
@SmiteDeluxe @lars-reimann @megalinter-bot