Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: potential stack overflow when computing types of lambda parameters #1173

Merged
merged 6 commits into from
May 16, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 16, 2024

Summary of Changes

Due to the interaction between the type computer and the scope provider, the previous approach to prevent endless recursion when computing the type of lambda parameters could fail. This PR provides a more robust implementation to fix this issue.

Copy link

github-actions bot commented May 16, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY git_diff yes no 0.14s
✅ TYPESCRIPT eslint 1 0 0 4.46s
✅ TYPESCRIPT prettier 1 0 0 1.13s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann lars-reimann force-pushed the type-computer-stack-overflow branch from 7e62aae to af619cd Compare May 16, 2024 19:37
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a07e893) to head (af619cd).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1173   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines        19238     19227   -11     
  Branches      4114      4119    +5     
=========================================
- Hits         19238     19227   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review May 16, 2024 19:41
@lars-reimann lars-reimann merged commit d89511e into main May 16, 2024
7 checks passed
@lars-reimann lars-reimann deleted the type-computer-stack-overflow branch May 16, 2024 19:41
lars-reimann pushed a commit that referenced this pull request May 16, 2024
## [0.16.0](v0.15.0...v0.16.0) (2024-05-16)

### Features

* eda plot view ([#1161](#1161)) ([a216743](a216743)), closes [#955](#955) [#986](#986)
* integrate version 0.25.0 of the `safe-ds` Python library ([#1174](#1174)) ([f357c38](f357c38))
* prefix keywords with `^` to treat them as identifiers ([#1172](#1172)) ([90bd47c](90bd47c))

### Bug Fixes

* potential stack overflow when computing types of lambda parameters ([#1173](#1173)) ([d89511e](d89511e))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant