fix: catch internal errors caused by wrong synthetic nodes created by completion provider #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… completion provider
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 96 96
Lines 18372 18377 +5
Branches 3843 3844 +1
=========================================
+ Hits 18372 18377 +5 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
Apr 6, 2024
## [0.10.0](v0.9.0...v0.10.0) (2024-04-06) ### Features * add settings to enable inlay hints individually ([#992](#992)) ([b0f3e62](b0f3e62)) * filter suggestions by node type ([#999](#999)) ([8d22e67](8d22e67)), closes [#998](#998) * forbid instance and static class members with same name ([#988](#988)) ([7fa6fd4](7fa6fd4)) * improved completion provider ([#997](#997)) ([61e776b](61e776b)), closes [#41](#41) * inlay hints for inferred types of lambda parameters ([#993](#993)) ([c064e0e](c064e0e)) * mark entire type cast as wrong if cast is impossible ([#991](#991)) ([72d4e2e](72d4e2e)) * profiling in EDA tool ([#954](#954)) ([854122c](854122c)), closes [#929](#929) * require `safe-ds-runner>=0.8.0,<0.9.0` ([#976](#976)) ([1003e6c](1003e6c)) * resolve name paths in `{[@link](https://github.com/link) }` tags in documentation ([#978](#978)) ([b59d6f0](b59d6f0)) ### Bug Fixes * catch internal errors caused by wrong synthetic nodes created by completion provider ([#1001](#1001)) ([8a6ab99](8a6ab99)) * chained memoized calls ([#987](#987)) ([df89291](df89291)) * correctly import declarations for member functions ([#983](#983)) ([79f9b08](79f9b08)) * error in Python generator for assignments with class/enum variant call as RHS ([#977](#977)) ([46b2bb2](46b2bb2)), closes [#975](#975) * generation of memoized class member calls ([#982](#982)) ([ed06aef](ed06aef)) * generation of Python imports ([#979](#979)) ([f69d836](f69d836)), closes [#974](#974) * invalid Python code generated for constructor calls ([#981](#981)) ([c7d006f](c7d006f)), closes [#980](#980) * Python generation for type casts ([#1000](#1000)) ([621ab86](621ab86))
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Triggering completion could lead to errors like
Error: SdsMap:result is not a valid reference id.. These are now caught, since the completion provider inevitably sometimes creates the wrong synthetic nodes before invoking the scope provider.