Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Replace @attribute, @constant, @optional, @required by one @value annotation #874

Closed
lars-reimann opened this issue Jul 1, 2022 · 1 comment · Fixed by #901
Closed

Replace @attribute, @constant, @optional, @required by one @value annotation #874

lars-reimann opened this issue Jul 1, 2022 · 1 comment · Fixed by #901
Assignees
@lars-reimann
Labels
enhancement 💡 New feature or request released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Jul 1, 2022 •
edited
Loading

Is your feature request related to a problem?

These annotations are mutually exclusive. Handling them as separate annotations makes the GUI logic considerably more complex. It's also hard to see that they exclude each other.

Desired solution

Have only one annotation that subsumes all 4 annotations. The user would then be able to select the desired effect (attribute, constant, optional, required) in the annotation form, as well as default type and value just like before if needed.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response
@lars-reimann lars-reimann added the enhancement 💡 New feature or request label Jul 1, 2022
@lars-reimann lars-reimann moved this to Backlog in API Editor Jul 1, 2022
@lars-reimann lars-reimann self-assigned this Jul 2, 2022
@lars-reimann lars-reimann moved this from Backlog to Todo in API Editor Jul 2, 2022
@lars-reimann lars-reimann mentioned this issue Jul 2, 2022
Open
3 tasks
@lars-reimann lars-reimann moved this from Todo to In Progress in API Editor Jul 2, 2022
@lars-reimann lars-reimann mentioned this issue Jul 2, 2022
Merged
@lars-reimann lars-reimann linked a pull request Jul 2, 2022 that will close this issue
feat: @value annotation to replace @attribute, @constant, @optional, @required #901
Merged
Repository owner moved this from In Progress to ✔️ Done in API Editor Jul 2, 2022
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

🎉 This issue has been resolved in version 1.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lars-reimann lars-reimann

Labels
enhancement 💡 New feature or request released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: @value annotation to replace @attribute, @constant, @optional, @required Safe-DS/API-Editor
1 participant
@lars-reimann