Skip to content
This repository has been archived by the owner on Jan 13, 2019. It is now read-only.

Ponder variations added, choose which color variations, limit variation depth #13

Open
ghost opened this issue Apr 22, 2018 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 22, 2018

Hi,

I've made some changes in my fork of leelaSabaki.
https://github.com/5525345551/LeelaSabaki

  • It passes the ponder variations to sabaki for 'play' as well as 'genmove'
  • Can choose to include 'black' or 'white' variations only
  • limit the variation depth

These are useful to use when reviewing a game.

Specify your player color e.g. '--white' and it will only include that colour, or '--white --black' to get both. For the non bot variations it uses the ponder console output.

I like to use '--flat' and '--limitdepth' so variations are 7 moves deep and can see it all easily.

I tried to have a '--depth n' moves but it will be difficult because of leelapath index is first non '-' arg.

This also needs a patch (dirty hack) to Sabaki, see my github fork of sabaki. https://github.com/5525345551/Sabaki
3 lines of code added.
Although it is buggy when stopping and starting a game because the sabaki move state is messed up. Sorry i dont know how to fix it better. :(

It would be good to put labels node.[LB] for variation first moves 'A', 'B', 'C', etc in the main branch of the game tree when the variations are added, but it required more hacks to sabaki.

Perhaps add this sgf 'LB' info to the JSON 'genmovelog' and then add that to the tree position node and board.markup in Sabaki?

Please take a look to see if you would like a pull request, but it is a bad hack :)

@ghost ghost changed the title some improvements about getting variations Ponder variations added, choose which color variations, limit variation depth Apr 22, 2018
@ghost
Copy link
Author

ghost commented Apr 24, 2018

@yishn I've done some more commits to Sabaki and LeelaSabaki to do the labelling of variations.

Turns out the detach and start new game is from a previous bug with Controllers and player switching. Not something I've broken with this commit hopefully. :)

It's all working quite nicely now. But it does seem that using command line options, needing to restart leelaSabaki to change options is not ideal.

@yishn
Copy link
Member

yishn commented Apr 24, 2018

@5525345551 I'm rather busy at the moment, so I can't promise anything, but I hope I can review your pull requests on the weekends.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant