Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axis labels are missing if the bins are empty #33

Open
EvgeniiChaikin opened this issue Oct 28, 2020 · 4 comments
Open

Axis labels are missing if the bins are empty #33

EvgeniiChaikin opened this issue Oct 28, 2020 · 4 comments

Comments

@EvgeniiChaikin
Copy link
Collaborator

EvgeniiChaikin commented Oct 28, 2020

For example, in one of my runs analysed using the pipeline that includes the latest updates from @jtrayford , you may take a look at this new plot

There is clearly some data present in the plot (the three blue dots). However, this is not sufficient to have at least one median bin with a non-zero value in it.

I suspect that since there is no data in the bins, the axis labels cannot be inferred. I guess if we get the labels directly from the data and not from the bins, this problem can be resolved? What do you think @JBorrow ?

@JBorrow
Copy link
Member

JBorrow commented Oct 28, 2020

I think you're correct, but I would have imagined that we would have picked this up from the points...

Do you have the data so I can try this myself?

@JBorrow
Copy link
Member

JBorrow commented Oct 28, 2020

Can you try the velociraptor-python branch fix_labels_for_low_data_volumes?

@EvgeniiChaikin
Copy link
Collaborator Author

Sure, you may use the data in /snap7/scratch/dp004/dc-chai1/my_cosmological_box/AGN4_L006188_00_dust_M16/

There is already a halo catalogue halo_1141.properties.0 so you do not need to run VR

I will look at the fix_labels_for_low_data_volumes branch as soon as I have got time.

@JBorrow
Copy link
Member

JBorrow commented Dec 14, 2020

I think unfortunately this is a case where it's out of our hands...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants