Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for BCI and BETA EULA to be in place #434

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Check for BCI and BETA EULA to be in place #434

merged 1 commit into from
Oct 23, 2024

Conversation

dirkmueller
Copy link
Member

No description provided.

dcermak
dcermak reviewed Apr 5, 2024
View reviewed changes
tests/test_all.py Outdated Show resolved Hide resolved
@dirkmueller dirkmueller force-pushed the license_test branch 5 times, most recently from 4499102 to c4d3125 Compare April 10, 2024 06:30
dcermak
dcermak reviewed Apr 29, 2024
View reviewed changes
tests/test_all.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Apr 29, 2024
View reviewed changes
tests/test_all.py Outdated Show resolved Hide resolved
@dirkmueller dirkmueller force-pushed the license_test branch 4 times, most recently from 24fd2d4 to d3f85fc Compare May 2, 2024 09:33
@dirkmueller dirkmueller mentioned this pull request Sep 16, 2024
Open
dcermak
dcermak reviewed Sep 16, 2024
View reviewed changes
tests/test_all.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Sep 16, 2024
View reviewed changes
tests/test_all.py Outdated Show resolved Hide resolved
@dcermak
Copy link
Collaborator

dcermak commented Sep 16, 2024

I've been staring at the code for a while now and I can't really figure out why the test_bci_eula_is_correctly_available function is skipped for the LTSS & LTSS FIPS containers on both sp3 and sp4. Is that by intention?

@dirkmueller
Copy link
Member Author

dirkmueller commented Sep 16, 2024 •
edited
Loading

I've been staring at the code for a while now and I can't really figure out why the test_bci_eula_is_correctly_available function is skipped for the LTSS & LTSS FIPS containers on both sp3 and sp4. Is that by intention?

testing LTSS containers only works if using TARGET=ibs-cr/ibs-released (but then you need credentials).

@dirkmueller dirkmueller force-pushed the license_test branch 2 times, most recently from 0d344b0 to 2a6e286 Compare September 16, 2024 14:49
@dcermak
Copy link
Collaborator

dcermak commented Sep 17, 2024

I've been staring at the code for a while now and I can't really figure out why the test_bci_eula_is_correctly_available function is skipped for the LTSS & LTSS FIPS containers on both sp3 and sp4. Is that by intention?

testing LTSS containers only works if using TARGET=ibs-cr/ibs-released (but then you need credentials).

Yes, we have such a test in the CI and it skips the FIPS images (grep from the full log):

2024-09-16T14:52:50.4585055Z tests/test_all.py::test_bci_eula_is_correctly_available[bci/bci-base-fips:15.4 from registry.suse.com/bci/bci-base-fips:15.4] 
2024-09-16T14:52:50.4773469Z [gw2] [ 22%] SKIPPED tests/test_all.py::test_bci_eula_is_correctly_available[bci/bci-base-fips:15.4 from registry.suse.com/bci/bci-base-fips:15.4]

dcermak
dcermak reviewed Sep 17, 2024
View reviewed changes
tests/test_all.py Outdated Show resolved Hide resolved
dcermak
dcermak reviewed Oct 23, 2024
View reviewed changes
tests/test_all.py
indirect=True,
)
def test_bci_eula_is_correctly_available(container: ContainerData) -> None:
"""Ensure that the BCI EULA exists iff it's not a LTSS container"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Ensure that the BCI EULA exists iff it's not a LTSS container"""
"""Ensure that the BCI EULA exists if it's not a LTSS container"""

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iff stands for "if and only if", so it was intentional. see https://www.dictionary.com/browse/iff

@dirkmueller dirkmueller merged commit b91b38f into main Oct 23, 2024
125 of 129 checks passed
@dirkmueller dirkmueller deleted the license_test branch October 23, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcermak dcermak dcermak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkmueller @dcermak