when I share the file with a remote group you cannot see the `shared` phrase beside shre command Icon. #93

navid-shokri · 2023-02-08T13:23:38Z

as you can see the shells file is shared:

but the shared flag is not visible in the sender panel.

The text was updated successfully, but these errors were encountered:

navid-shokri · 2023-02-08T14:04:31Z

I think the root cause is the result of this request that is made by the file application:

{
	"PROPFIND": {
		"scheme": "https",
		"host": "oc1.docker",
		"filename": "/remote.php/dav/files/einstein/",
		"remote": {
			"Address": "172.18.0.2:443"
		}
	}
}

navid-shokri · 2023-02-13T11:08:40Z

guess what?
I finally found the code that fills the Propfind request and its share_type section:

https://github.com/pondersource/core/blob/master/apps/dav/lib/Connector/Sabre/SharesPlugin.php
https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/apps/dav/lib/Connector/Sabre/SharesPlugin.php#L131

which IShareManager in this line is
https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/apps/dav/lib/Connector/Sabre/SharesPlugin.php#L76

is this class:

https://github.com/pondersource/core/blob/master/lib/private/Share20/Manager.php

you can find its instantiation in this line:

https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/lib/private/Server.php#L894

navid-shokri · 2023-02-13T15:01:35Z

oh, It seems too easy to solve 😄

according to these lines:
https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/lib/private/Share20/Manager.php#L156

https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/lib/private/Share20/Manager.php#L1263

there is an iterator that iterates all known share providers and gets all shared files from them.

these known share providers are listed there:
https://github.com/pondersource/core/blob/70917902ec43e7a7cd87f0dc2b149f0ab83a73c3/apps/dav/lib/Connector/Sabre/SharesPlugin.php#L132

so as a solution, we can just add \OCP\Share::SHARE_TYPE_REMOTE in that array 🎉

navid-shokri · 2023-02-14T16:38:09Z

So, I added all of the share types and the getIdentifier function in new created XShareProvider class, but there is an error related to @michielbdejong changes that should be resolved in a pair programming session.

at this line:

rd-sram-integration/federatedgroups/lib/AppInfo/Application.php

Line 438 in 152b93f

return $fedShareManager->getExternalManager($user->getUID());

the getExternalManager function is calling with just one argument while the signature of the function needs two arguments:

rd-sram-integration/federatedgroups/lib/FederatedFileSharing/FedShareManager.php

Line 417 in 152b93f

public function getExternalManager($userId = null, $ocmShareType){

navid-shokri · 2023-02-17T15:05:31Z

so the getAllSharedBy is implemented and all shared files in REMOTE_GROUP are fetched from the database.

navid-shokri · 2023-02-17T15:09:11Z

but the response to the PROPFIND request still does not show the share_type 7 for the files that are shared with remote groups.

navid-shokri · 2023-02-17T15:23:35Z

so I added this Line of code

$shareTypes[] = 7;

in this spot:

https://github.com/pondersource/core/blob/5a381c888ed6db83b0991b0d6509a1aa1197eca9/apps/dav/lib/Connector/Sabre/SharesPlugin.php#L215

and all the files in the backend responses are marked as shared with the remote group in the response.
but the Shared flag is still missing in the file application GUI. So, the Conclusion is: we should look into the front code for finding the reason of missed shared flag in the GUI

navid-shokri · 2023-02-20T21:10:00Z

@soltanireza65
can you read this thread and find out the mechanism of the shared phrase appearance in UI?

soltanireza65 · 2023-02-27T08:56:25Z

have created a PL in pondersource/core#6
this fixed the sharing side and now share icon is showing

the thing that is not working is receiver is not able to accept it.
error: invalid share id

navid-shokri · 2023-02-27T09:06:11Z

I am suspicious about whether your solution is correct or not because I expected that this share request should be sent by Notification.php class that is located in FederatedGroup > lib > FederatedFileSharing. I will check it again to find the should We fix the problem from an upper layer or should continue with your solution

navid-shokri · 2023-02-28T16:05:39Z

so I found that the FederatedGroupShareProvider should be copied from lib\FederatedFileSharing. I did those modifications.

this comment is related to #110

navid-shokri · 2023-02-28T16:57:54Z

So, currently we have two problems:

1- the shared flag is not shown beside shared file name in sender side (einstein).

2- the shared file is accepted but it is not listed in receiver side (marie). and this Error is shown in side the log:

{"reqId":"wRsdZlhCjn5jgBMQToJ9","level":3,"time":"2023-02-28T16:50:09+00:00","remoteAddr":"172.18.0.6","user":"marie","app":"no app in context","method":"PROPFIND","url":"\/remote.php\/dav\/files\/marie\/","message":"Exception: {\"Exception\":\"Sabre\\\\HTTP\\\\ClientHttpException\",\"Message\":\"Unauthorized\",\"Code\":401,\"Trace\":\"
#0 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Client.php(229): Sabre\\\\HTTP\\\\Client->send()\\n
#1 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Storage\\\/DAV.php(264): Sabre\\\\DAV\\\\Client->propFind()\\n
#2 \\\/var\\\/www\\\/html\\\/apps\\\/rd-sram-integration\\\/federatedgroups\\\/lib\\\/Files_Sharing\\\/External\\\/Storage.php(327): OC\\\\Files\\\\Storage\\\\DAV->propfind()\\n
#3 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Storage\\\/Common.php(637): OCA\\\\FederatedGroups\\\\Files_Sharing\\\\External\\\\Storage->getPermissions()\\n
#4 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Wrapper.php(586): OC\\\\Files\\\\Storage\\\\Common->getMetaData()\\n
#5 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Availability.php(459): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Wrapper->getMetaData()\\n
#6 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Encryption.php(177): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Availability->getMetaData()\\n
#7 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Checksum.php(206): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Encryption->getMetaData()\\n
#8 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Storage\\\/Wrapper\\\/Wrapper.php(586): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Checksum->getMetaData()\\n
#9 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Cache\\\/Scanner.php(115): OC\\\\Files\\\\Storage\\\\Wrapper\\\\Wrapper->getMetaData()\\n
#10 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/Cache\\\/Scanner.php(150): OC\\\\Files\\\\Cache\\\\Scanner->getData()\\n
#11 \\\/var\\\/www\\\/html\\\/lib\\\/private\\\/Files\\\/View.php(1569): OC\\\\Files\\\\Cache\\\\Scanner->scanFile()\\n
#12 \\\/var\\\/www\\\/html\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/Directory.php(295): OC\\\\Files\\\\View->getDirectoryContent()\\n
#13 \\\/var\\\/www\\\/html\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/SharesPlugin.php(171): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\Directory->getChildren()\\n
#14 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/WildcardEmitterTrait.php(89): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\SharesPlugin->handleGetProperties()\\n
#15 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1052): Sabre\\\\DAV\\\\Server->emit()\\n
#16 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(984): Sabre\\\\DAV\\\\Server->getPropertiesByNode()\\n
#17 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1662): Sabre\\\\DAV\\\\Server->getPropertiesIteratorForPath()\\n
#18 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(1642): Sabre\\\\DAV\\\\Server->writeMultiStatus()\\n
#19 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/http\\\/lib\\\/Sapi.php(83): Sabre\\\\DAV\\\\Server->Sabre\\\\DAV\\\\{closure}(*** sensitive parameters replaced ***)\\n
#20 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(490): Sabre\\\\HTTP\\\\Sapi::sendResponse()\\n
#21 \\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(253): Sabre\\\\DAV\\\\Server->invokeMethod()\\n
#22 \\\/var\\\/www\\\/html\\\/apps\\\/dav\\\/lib\\\/Server.php(348): Sabre\\\\DAV\\\\Server->start()\\n
#23 \\\/var\\\/www\\\/html\\\/apps\\\/dav\\\/appinfo\\\/v2\\\/remote.php(31): OCA\\\\DAV\\\\Server->exec()\\n
#24 \\\/var\\\/www\\\/html\\\/remote.php(165): require_once('\\\/var\\\/www\\\/html\\\/a...')\\n
#25 {main}\",\"File\":\"\\\/var\\\/www\\\/html\\\/lib\\\/composer\\\/sabre\\\/http\\\/lib\\\/Client.php\",\"Line\":163}"}

navid-shokri · 2023-03-02T07:01:18Z

I finally found the code location that was responsible to marking the file as shared file.

https://github.com/pondersource/core/blob/5a381c888ed6db83b0991b0d6509a1aa1197eca9/core/js/share.js#L222

navid-shokri · 2023-03-02T07:32:32Z

So finally I found the code that indicate shared flag should be shown or not:

https://github.com/pondersource/core/blob/fa9f0b40e8397f64cfc9682ea1b6bed916ae9c5d/apps/files_sharing/js/share.js#L152

navid-shokri · 2023-03-02T07:36:13Z

good news is @soltanireza65 had been change this line of code so far:
https://github.com/pondersource/core/blob/fa9f0b40e8397f64cfc9682ea1b6bed916ae9c5d/core/js/share.js#L12

I should change this file:

https://github.com/pondersource/core/blob/fa9f0b40e8397f64cfc9682ea1b6bed916ae9c5d/apps/files_sharing/js/share.js#L152

navid-shokri · 2023-03-02T07:42:28Z

Done and shared flag is visible beside shared file. 🏁

navid-shokri · 2023-03-02T07:45:49Z

I faced with another problem. when I clicked on file row and the sidebar opens the flag will be disappeared. ⚠️

navid-shokri · 2023-03-02T08:33:36Z

I found that when we click on a file there is three API calls: ℹ️

1- GET /ocs/v2.php/apps/files_sharing/api/v1/shares?format=json&path=%2Fgroup&reshares=true HTTP/1.1
Host: oc1.docker

2- GET /ocs/v2.php/apps/files_sharing/api/v1/shares?format=json&path=%2Fgroup&shared_with_me=true HTTP/1.1
Host: oc1.docker

3- PROPFIND /remote.php/dav/systemtags-relations/files/15 HTTP/1.1
Host: oc1.docker

which the first one does not return the desired information about share file with REMOTE_GROUP

navid-shokri · 2023-03-02T09:50:16Z

So I found the final solution:
regarding that we are inheriting the federatedgroups>FederatedGroupShareProvider from federatedFileSharing>FederatedShareProvider and this line of code is trying to call getSharesBy function the parent function is calling due to lack of function overriding in federatedgroups>FederatedGroupShareProvider class.

so we should override that function. it could be helpful.

navid-shokri · 2023-03-02T10:02:06Z

Done 🏁
Now the listing share recipient is shown as you can in attached picture.

But the name of recipient is Empty. ⚠️
It should be checked that re recipient is not stored in database or it is not fetched in query time.

navid-shokri · 2023-03-02T14:55:08Z

so finally I resolve this issue Completly by this commit: 🎉 🏁
pondersource/core@e5e3da4

navid-shokri mentioned this issue Feb 8, 2023

fill share type with correct value (7 | SHARE_TYPE_REMOTE_GROUP) on creating user-to-group ocm share. #87

Closed

navid-shokri self-assigned this Feb 10, 2023

navid-shokri linked a pull request Feb 13, 2023 that will close this issue

set identifier for new created share providers #94

Merged

navid-shokri mentioned this issue Feb 28, 2023

Undefined index: password #72

Closed

navid-shokri closed this as completed Mar 2, 2023

navid-shokri mentioned this issue Mar 2, 2023

the group shared file could not be accepted in marie (receiver) side and it is not listed in shared file. #114

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

when I share the file with a remote group you cannot see the `shared` phrase beside shre command Icon. #93

when I share the file with a remote group you cannot see the `shared` phrase beside shre command Icon. #93

navid-shokri commented Feb 8, 2023

navid-shokri commented Feb 8, 2023 •

edited

Loading

navid-shokri commented Feb 13, 2023 •

edited

Loading

navid-shokri commented Feb 13, 2023

navid-shokri commented Feb 14, 2023

navid-shokri commented Feb 17, 2023

navid-shokri commented Feb 17, 2023

navid-shokri commented Feb 17, 2023

navid-shokri commented Feb 20, 2023

soltanireza65 commented Feb 27, 2023

navid-shokri commented Feb 27, 2023

navid-shokri commented Feb 28, 2023 •

edited

Loading

navid-shokri commented Feb 28, 2023

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023 •

edited

Loading

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023 •

edited

Loading

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023

when I share the file with a remote group you cannot see the shared phrase beside shre command Icon. #93

when I share the file with a remote group you cannot see the shared phrase beside shre command Icon. #93

Comments

navid-shokri commented Feb 8, 2023

navid-shokri commented Feb 8, 2023 • edited Loading

navid-shokri commented Feb 13, 2023 • edited Loading

navid-shokri commented Feb 13, 2023

navid-shokri commented Feb 14, 2023

navid-shokri commented Feb 17, 2023

navid-shokri commented Feb 17, 2023

navid-shokri commented Feb 17, 2023

navid-shokri commented Feb 20, 2023

soltanireza65 commented Feb 27, 2023

navid-shokri commented Feb 27, 2023

navid-shokri commented Feb 28, 2023 • edited Loading

navid-shokri commented Feb 28, 2023

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023 • edited Loading

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023 • edited Loading

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023

navid-shokri commented Mar 2, 2023

when I share the file with a remote group you cannot see the `shared` phrase beside shre command Icon. #93

when I share the file with a remote group you cannot see the `shared` phrase beside shre command Icon. #93

navid-shokri commented Feb 8, 2023 •

edited

Loading

navid-shokri commented Feb 13, 2023 •

edited

Loading

navid-shokri commented Feb 28, 2023 •

edited

Loading

navid-shokri commented Mar 2, 2023 •

edited

Loading

navid-shokri commented Mar 2, 2023 •

edited

Loading