Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skiplink component #812

Merged
merged 3 commits into from
Mar 15, 2021
Merged

Add skiplink component #812

merged 3 commits into from
Mar 15, 2021

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Mar 12, 2021 •
edited
Loading

READY FOR REVIEW

Summary

  • Add skiplink as a Tailwind component (Note: I increase the font size a bit since I think it's a bit too small in Decanter 6).
  • Also note: I did npm run publish and npm run wind this time so perhaps that's why there are so many new lines added. I only did npm run build in previous PRs. This seems to fix the issue you saw where the decanter-utilities.css file was bigger than the main decanter.css file.

Needed By (Date)

  • When does this need to be merged by?

Urgency

  • How critical is this PR?

Steps to Test

  1. Go to preview build.
  2. When the page finish loading, hit tab with the keyboard - check that the skip link button show up.

Affected Projects or Products

  • Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

  • JIRA ticket
  • Other PRs
  • Any other contextual information that might be helpful (e.g., description of a bug that this PR fixes, new functionality that it adds, etc.)
  • Anyone who should be notified? (@mention them here)

See Also

@yvonnetangsu yvonnetangsu requested a review from sherakama March 12, 2021 19:23
@sherakama
Copy link
Member

  • Also note: I did npm run publish and npm run wind this time so perhaps that's why there are so many new lines added. I only did npm run build in previous PRs. This seems to fix the issue you saw where the decanter-utilities.css file was bigger than the main decanter.css file.

https://github.com/SU-SWS/decanter/blob/ADAPT-2059-skiplink/package.json#L12

the wind command only compiles the one file. The build/publish commands should compile all the files. We have been using the build command as it is pretty code and easy to read while we lack documentation. I want to eventually move to npm run publish but we need more documentation first.

@yvonnetangsu
Copy link
Member Author

  • Also note: I did npm run publish and npm run wind this time so perhaps that's why there are so many new lines added. I only did npm run build in previous PRs. This seems to fix the issue you saw where the decanter-utilities.css file was bigger than the main decanter.css file.

https://github.com/SU-SWS/decanter/blob/ADAPT-2059-skiplink/package.json#L12

the wind command only compiles the one file. The build/publish commands should compile all the files. We have been using the build command as it is pretty code and easy to read while we lack documentation. I want to eventually move to npm run publish but we need more documentation first.

That sounds good. I just merged the new changes in and going to run build again to resolve the conflict.

@yvonnetangsu
Merge branch 'v7' into ADAPT-2059-skiplink with new npm run build
76683dc 
* v7:
  ADAPT-1073: Unstructured WYSIWYG content styles as TW component (#813)

# Conflicts:
#	dist/decanter.css
sherakama
sherakama reviewed Mar 15, 2021
View reviewed changes
dist/decanter-base.js Outdated Show resolved Hide resolved
sherakama
sherakama approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@sherakama sherakama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the JS files in the dist directory and add them to the .gitignore file then this is GTG.

@yvonnetangsu yvonnetangsu merged commit 895688d into v7 Mar 15, 2021
@yvonnetangsu yvonnetangsu deleted the ADAPT-2059-skiplink branch March 15, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama sherakama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yvonnetangsu @sherakama