-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create documentation on spacing #288
Comments
Spacing rules:1. Gutters
2. Screen Edge
3. Element Spacing
4. Vertical Rhythm
5. Typography Scale
|
@yvonnetangsu @kerri-augenstein @JohnHolleman @josephgknox I've started to put together the public documentation for the spacing systems. These will benefit from screenshots of the figma documentation but let me know if I have captured the general use case and methodology for application for each of these space/size systems. |
@sherakama : |
for item 3 (element spacing) the namespace should be For 4 & 5, you are right, I got those backwards. |
Chatted with both John H and Kerri via Slack on this. All three of us are happy with the state of this, with thanks to Shea for stubbing it out. One semi-related comment that John brought up, which I am re-posting here is: did we get the concept that the total width of the 12 columns is not fixed at each breakpoint but expands as the viewport expands (with the exception of XXL which is a centered 1500px); would be under screen edge. |
Oh, that would be a good addition. Thanks for the feedback. Next steps for this will be to flush it out so that they are not just bullet points and to add pretty pictures and examples. |
I have created a "Spacing" page on the Wiki at https://github.com/SU-SWS/decanter/wiki/Spacing, which is now also linked to from the "Standards and Conventions" page under "Spacing Rules." Let me know if this organization of the documentation is OK or if it should change. I have refactored the bullets on this thread into sentences on the new Wiki page, placing the content for each rule in an appropriate order and separating definitions from developer notes. Also, I have begun adding images/visual guides that highlight each rule. I can continue to add more images and visual guides to the rules without any, but can also use another set of eyes on this to see if we're on the right path. |
Thank you for putting this together, @josephgknox! This looks very nice and the images really help - totally on the right path. I only saw a couple minor things. I asked @sherakama about namespace for Element Spacing, and he said it should be For Screen Edges, I believe the max centered container width 1500px doesn't immediately kick in at the beginning of 2XL breakpoint, but rather at 1700px since it's still honoring the 100px screen edge on each side. |
Thanks, @yvonnetangsu! Good catch on the distinction between 1500px and 1700px, too. Those two items have been edited. |
Thank you both so much. This looks great. I'm going to call this done. We can create new tickets for revisions. |
Document and explain the rules behind using:
and publish to the web somewhere. Either as a wiki entry in github or on the website somewhere.
The text was updated successfully, but these errors were encountered: