Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of current share button #1105

Closed
Binnette opened this issue May 15, 2019 · 4 comments · Fixed by #1142
Closed

Review of current share button #1105

Binnette opened this issue May 15, 2019 · 4 comments · Fixed by #1142

Comments

@Binnette
Copy link
Contributor

Hi, here is a quick review of the "share" buttons:
image

We have:

  • Google+ => but Google+ is dead since since april 2019 (https://plus.google.com/)
  • Twitter, Facebook, Pocket, Delicious, Mail =>

I think that we can remove Google+ and instead add a button "copy to clipboard". This new button will copy the link to the original article in clipboard. Then users can paste the link every where : in a document, in a mail, in a messenger ans so on. What do you think ?

@jtojnar jtojnar added this to the 2.19 milestone May 15, 2019
@jtojnar
Copy link
Member

jtojnar commented May 15, 2019

Yeah removing g+ is a good idea.
Copy to clipboard sounds good too, though that one is a more complicated since we need to come up with a UI to let the user know that the link was copied.

Also related #719 (implementation in #1035)

@aslmx
Copy link

aslmx commented May 23, 2019

Quick (and not yet educated) thought: why not use the kind of Toast notification that is used to indicate errors (e.g. the errors that are shown when an item can't be marked as read etc.)

@jtojnar
Copy link
Member

jtojnar commented May 23, 2019

Yup, that was my thinking as well.

If anyone has a capacity to tackle this, it should be pretty easy.

@jtojnar
Copy link
Member

jtojnar commented Aug 7, 2019

#1121 removed the G+ & del.icio.us, so we can focus on the copy button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants