Add missing fields to Chapter and update TimeInterval
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
StaehliJ
approved these changes
May 21, 2024
data/src/main/java/ch/srg/dataProvider/integrationlayer/data/remote/TimeInterval.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scope of SRGSSR/pillarbox-android#460, we'd like to replace Pillarbox models of the integration layer objects with those from data provider.
To do so, we need the following changes proposed in this PR:
fullLengthMarkInandfullLengthMarkOuttoChapter.type,markIn, andmarkOutnullable inTimeInterval.I've bump the library version to 0.10.0 since the changes in
TimeIntervalcould break if someone is using that class. Let me know if I should use an other version.