Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Binary Data #470

Closed
vanthome opened this issue Sep 25, 2016 · 6 comments
Closed

Support Binary Data #470

vanthome opened this issue Sep 25, 2016 · 6 comments

Comments

@vanthome
Copy link

While Kafka supports binary data, this module only seems to support text based data.
It would be great if you could support binary data based on streams and buffer.

@hyperlink
Copy link
Collaborator

Have you tried setting the encoding option to buffer ?

@vanthome
Copy link
Author

will try and let you know

@pcothenet
Copy link

I've been using this module with Avro for a couple months, works great.

@hyperlink
Copy link
Collaborator

@vanthome did setting the encoding option to buffer work for you?

@MedGhassen
Copy link

@hyperlink @vanthome I have tried setting the Encoding Option in the Consumer to 'buffer' and it is working fine . Thank you very much.
It could be very nice to enhance the documentation by saying that it is possible to transfer binary data through buffers by setting the encoding option of the Consumer and that NO prior setting for the producer are required .
In other word that it does not depend on the producer's encoding but it depends on the consumer's encoding .
Thank you very much :D

hyperlink added a commit that referenced this issue Oct 3, 2016
@kevinswarner
Copy link

kevinswarner commented Apr 14, 2017

It appears that the "encoding" option is available in the ConsumerGroup, but this is not documented very well. It would be helpful to provide a more complete and clear documentation for the ConsumerGroup option. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants