Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with upcoming ggplot2 version #3

Open
teunbrand opened this issue Mar 19, 2023 · 2 comments
Open

Issue with upcoming ggplot2 version #3

teunbrand opened this issue Mar 19, 2023 · 2 comments

Comments

@teunbrand
Copy link

Hi there,

While preparing for a new release of ggplot2, our reverse dependency check showed that your package's vignette has broken.
More specifically, we believe that the vignette can no longer be built due to plots being saved to disk.
We generally don't recommend saving plots to disk, partially because the saved objects may contain internal code that is version dependent.
ggplot2 tries to keep the exported functions stable, but makes no promise about internal code.
In this case, such an internal function has changed (for appealing reasons), but it invalidates plots saved to disk with previous versions of ggplot2.

In particular, we believe that the plots like the ones below have become invalid:

```{r fig.align="center", warning=FALSE, message=FALSE}
sample[[1]]
```

If it is very inconvenient to circumvent saving plots to disk, please consider this issue an advance warning. The saved plots might have to be regenerated with the upcoming version of ggplot2. You can test the upcoming changes with the current release candidate, that can be installed with devtools::install_github('tidyverse/[email protected]').

Best wishes,
Teun

@teunbrand
Copy link
Author

Hello there,

Once again, we have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break TCIU.

The issue remains the same as the plot above.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this issue informs you in a timely manner.

@teunbrand
Copy link
Author

This is just a kind reminder that the release of ggplot2 is scheduled soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant