Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp CMake support #1118

Open
wants to merge 103 commits into
base: master
Choose a base branch
from
Open

Revamp CMake support #1118

wants to merge 103 commits into from

Conversation

Krzmbrzl
Copy link
Contributor

@Krzmbrzl Krzmbrzl commented Jan 3, 2024 •
edited
Loading

Fixes #1115
Fixes #1152
Fixes #1122
Fixes #1094
Fixes #1159
Fixes #644

@vadz
Copy link
Member

vadz commented Jan 11, 2024

Do you think we should wait for this before making SOCI 4.1.0 release or can we leave this change until a later 4.1.x?

@Krzmbrzl
Copy link
Contributor Author

Do you think we should wait for this before making SOCI 4.1.0 release or can we leave this change until a later 4.1.x?

Well, it would probably be nice if 4.1 had this already, but it's more of a nice-to-have. So I guess you don't have to wait for this PR to be done.
However, my planned timeline for this PR is to get this finished within the next two to three weeks. Depending on your plans for 4.1, waiting for such a time period would be okay? But as I said: it's optional.

Unrelated to this PR, I would appreciate if #992 made it into 4.1 though :)

This was referenced Feb 17, 2024
Open
Closed
@Krzmbrzl Krzmbrzl force-pushed the revamp-cmake branch 7 times, most recently from 0b83bb8 to e1e4433 Compare February 17, 2024 16:02
@Krzmbrzl Krzmbrzl force-pushed the revamp-cmake branch 18 times, most recently from e4b2e0d to 39b9037 Compare February 27, 2024 19:04
@Krzmbrzl Krzmbrzl force-pushed the revamp-cmake branch 2 times, most recently from 227e55b to be77273 Compare January 3, 2025 16:33
@vadz vadz mentioned this pull request Jan 16, 2025
Open
@Krzmbrzl Krzmbrzl marked this pull request as ready for review January 26, 2025 19:12
@Krzmbrzl Krzmbrzl requested a review from vadz January 26, 2025 19:12
@Krzmbrzl
Copy link
Contributor Author

I think this is now ready for the next round of review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phetdam phetdam phetdam left review comments

@vadz vadz Awaiting requested review from vadz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Krzmbrzl @vadz @Spixmaster @phetdam