Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy setting is hardcoded for Jersy JAXRS Implementation #22

Closed
pendula95 opened this issue Sep 5, 2019 · 3 comments · Fixed by #28
Closed

Proxy setting is hardcoded for Jersy JAXRS Implementation #22

pendula95 opened this issue Sep 5, 2019 · 3 comments · Fixed by #28

Comments

@pendula95
Copy link

pendula95 commented Sep 5, 2019 •
edited
Loading

With current implementation proxy settings will only work with Jersy JAXRS provider.
Provide a way to pass configuration to SmartIdClient that will work with all implementations of JAXRS.
Issue is that Proxy is not specified by JAXRS, instead maybe it would be better to provide a way to pass Client to SmartIdClient.
With current implementation any ClientConfig settings can not be used on WildFly or Jboss.
@andrevka andrevka mentioned this issue Sep 23, 2019
Merged
@aasaru
Copy link
Contributor

aasaru commented Sep 24, 2019

@pendula95 could you please verify if #28 solves your problem. Thanks!

@pendula95
Copy link
Author

pendula95 commented Sep 24, 2019 •
edited
Loading

Yes this solves the issue but there is an error. I already commented on PR.

@aasaru
Copy link
Contributor

aasaru commented Sep 26, 2019

Thanks @pendula95 for taking time to test it and also for tracking down a bug.
The bug is now fixed (45d2d3d) and the PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pendula95 @aasaru