Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

random sampling for reference images? #38

Open
seojpark91 opened this issue Jun 9, 2023 · 1 comment
Open

random sampling for reference images? #38

seojpark91 opened this issue Jun 9, 2023 · 1 comment

Comments

@seojpark91
Copy link

Hi, thanks for the amazing work! I have some questions regarding your code:

  1. consequent frames? : In the paper, it states that consequent frames are used as the input of TransVOD. However, in this line,

    ref_img_ids = random.sample(sample_range, self.num_ref_frames)

    reference samples are randomly selected ignoring consequent nature of frames.

  2. remove current frame from batch? : in this line

    if self.filter_key_img and img_id in sample_range:
    the code removes current img_id from the sample range. In the paper, it states that adjacent frames are fed into the code. Am I missing something here?

@tabsun
Copy link

tabsun commented Jun 24, 2024

same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants