Homepage #35
Homepage #35
Conversation
Added bulma
Co-authored-by: Gabriel Flynn <[email protected]>
Co-authored-by: Gabriel Flynn <[email protected]>
Co-authored-by: Gabriel Flynn <[email protected]>
Co-authored-by: Gabriel Flynn <[email protected]>
…en navBar and login-page
…<a>, also formatted index.tsx, Layout.tsx, and _variables.sccss.
…this is in the footer branch my bad)
… is used on the homepage
There was a problem hiding this comment.
The homepage looks amazing! I just requested a few minor changes, .
One thing we might want to consider is changing the webp images we have to png/jpeg/etc: `linkedin-in-logo.webp' and 'facebook-logo.webp' since webp is relatively new to the safari browser (sep of 2020 if I understand it correctly) and the bandwidth we'd save would be pretty neglible for our application. There's a pretty interesting chart thing that shows you the percent of browsers that support it here. 91.36% of all users browsers would support the features of webp we need as far as I can tell
|
Also we can save this for another pr but I think we might want to play around with the breakpoints on the newsletter - it looks a little weird on certain screen sizes (I think we could resolve this by making the div it's in smaller so it doesn't stretch as seen in the gif and just have it centered - the whitespace to the left and right of the fields is what makes it look out of place) |
…he footer one that needs to be applied to several classes))
Co-authored-by: Gabriel Flynn <[email protected]>
…as discussed in our last Saturday meeting)
|
Nice. I'll go ahead and merge it now so anabel can start working on her
issue.
I'll look for replacements for the webp images later this week.
…On Sat, Jan 23, 2021 at 7:04 PM Gabriel Flynn ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good! Last thing that needs to be done is merging the dev branch
into the homepage branch - looks like there is a merge conflict with the
theming/variables.scss file
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APCW4573IJQZCZVF6TTOW43S3NWZPANCNFSM4WCWMVPQ>
.
|
Homepage is finalized (for now, we can add stuff if later if we want to)
We can also put the instagram iframe in the homepage instead of the newsletter form (we can discuss this in our next meeting)