Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles course #365

Merged
merged 10 commits into from
Apr 25, 2024
Merged

Roles course #365

merged 10 commits into from
Apr 25, 2024

Conversation

BramMeir
Copy link
Contributor

closes #361
closes #362

  • Refactor assigning the role of a user in a course, making it possible to assign the assistant/teacher role without the need for an assistant/teacher object in the backend.
  • Fix that you can't leave the course as the last teacher, to prevent ending up with a course without teachers

@BramMeir BramMeir added the frontend Issues regarding the frontend label Apr 22, 2024
@BramMeir BramMeir added this to the Final milestone milestone Apr 22, 2024
@BramMeir BramMeir self-assigned this Apr 22, 2024
Copy link
Contributor

@EwoutV EwoutV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍇

@EwoutV EwoutV merged commit 7e57b82 into development Apr 25, 2024
3 checks passed
@EwoutV EwoutV deleted the roles-course branch April 25, 2024 14:58
DeLany123 pushed a commit that referenced this pull request Apr 29, 2024
* chore: layout for selecting role

* chore: join logic

* chore: fix filter users

* chore: assistant/teacher role switch

* chore: leave course + fix not last teacher

* fix: backend check on last teacher

* fix: not possible to remove last teacher in frontend

* chore: linting

* fix: comments

* fix: backend test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues regarding the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: impossible to delete last teacher Frontend: assigning assistant role
2 participants