Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test models only have the first row for constant values #63

Open
enekomartinmartinez opened this issue Dec 18, 2020 · 1 comment
Open

Comments

@enekomartinmartinez
Copy link
Contributor

Hi,
The newest test I added only have first row for constant values output.tab is like:

Time FINAL TIME INITIAL TIME oscilating var constant var SAVEPER TIME STEP
0 2 0 0.841471 100 1 1
1 0.410781 1
2 0.893855 1

is this okay for everyone, I solved this issue in PySD adding the following lines to repeat the value over the rows:

# if for Vensim outputs where constant values are only in the first row
if np.isnan(expected[col].values[1:]).all():
    expected[col] = expected[col].values[0]

is it possible to do something similar in the other repositories that are using this repo? This way we avoid post-processing output.tab files and make easier contributing with new test models.

@JamesPHoughton
Copy link
Contributor

@ivan-perl, will this work with your SDE test setup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants