Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Supports UIKit for macOS #2743

Closed
3 tasks done
dreampiggy opened this issue Jun 4, 2019 · 8 comments
Closed
3 tasks done

Feature Request: Supports UIKit for macOS #2743

dreampiggy opened this issue Jun 4, 2019 · 8 comments
Labels
feature request macOS AppKit for macOS
Milestone

Comments

@dreampiggy
Copy link
Contributor

dreampiggy commented Jun 4, 2019

New Issue Checklist

Issue Info

Info Value
Platform Name macOS (UIKit)
Platform Version 10.15.0
SDWebImage Version 5.0.5
Integration Method all
Xcode Version Xcode 11

Issue Description and Steps

See the documentation: Creating a Mac Version of Your iPad App

Seems there are a new macro to detect the UIKit for macOS. TARGET_OS_UIKITFORMAC. We can use this to the SD_UIKIT and fix for platform detection.

Maybe this also need CocoaPods support . But at least, we can support Carthage user first.

@dreampiggy dreampiggy added the macOS AppKit for macOS label Jun 4, 2019
@dreampiggy dreampiggy pinned this issue Jun 4, 2019
@kinarobin
Copy link
Member

Interesting!

@rjchatfield
Copy link

MD5 is not supported on macOS. I believe it’s still used for hashing URLs to file paths.

@stale
Copy link

stale bot commented Jul 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Jul 5, 2019
@dreampiggy dreampiggy removed the stale label Jul 5, 2019
@stale
Copy link

stale bot commented Aug 4, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

@stale stale bot added the stale label Aug 4, 2019
@dreampiggy dreampiggy removed the stale label Aug 5, 2019
@fishandphil
Copy link

+1

@dreampiggy dreampiggy added this to the Future milestone Aug 6, 2019
@dreampiggy
Copy link
Contributor Author

dreampiggy commented Aug 12, 2019

Current Status:

  • Build SDWebImage on UIKit for macOS (Catalyst): Works with little Xcode build settings changes
  • Run SDWebImage iOS Demo on macOS: Works, but need workaround for UIKit's bug behavior on macOS. See more on later PR.
  • Update test case on UIKit for macOS: Done
  • Update the XCFramework build script of UIKit for macOS: Done
  • Update other related SDWebImage repo of UIKit for macOS: TODO

Screenshot1

WechatIMG82

@dreampiggy
Copy link
Contributor Author

Current working branch: project_uikit_macos

@dreampiggy
Copy link
Contributor Author

Catalyst for macOS is supported !

Both the Carthage/SwiftPM, and even CocoaPods (It need you to tweak the code sign issue), support the UIKit for macOS.

You can also use the SDWebImage XCFramework build scheme, to build the XCFramework contains all the 8 platforms into one on Xcode 11:

  • iOS
  • iOS Simulator
  • tvOS
  • tvOS Simulator
  • watchOS
  • watchOS Simulator
  • macOS
  • macOS Catalyst

@dreampiggy dreampiggy modified the milestones: Future, 5.2.0 Aug 19, 2019
@dreampiggy dreampiggy unpinned this issue Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request macOS AppKit for macOS
Projects
None yet
Development

No branches or pull requests

4 participants