-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HHC01423I in the log is badly formatted #480
Comments
On Windows, it works perfectly. On Linux (KDE Neon 5.24) however, I am seeing a properly formatted Continuing research... |
Okay, when I make the suggested change, now I get difference (worse IMO) results: On Windows, the message completely disappears from both the screen and the logfile. That is to say, message On Linux (KDE Neon 5.24), the message still does not appear on the screen (i.e. same (incorrect!) behavior as before), but it does now only appear once in the logfile (and still appears to be properly formatted too). So in my opinion, your suggested change only makes matters worse. While it does indeed slightly improve(?) things on Linux, it only makes matters worse on Windows. Without the change things work perfectly on Windows. With the change, the message completely disappears! So I am going to reject your suggested change. More research is obviously needed (by someone else more experienced with Linux! Not me!) as the problem appears to only occur on Linux and not Windows. I suspect it has something to do with the way our file redirection is being handled for Linux builds (i.e. our calls to I am going to leave this issue open but am going to remove myself as the assignee, in the hope that someone else more experienced at Linux can take ownership of it instead, and figure out what the frick is going on and how best to fix it. Thank you, Enrico, for reporting it. |
I just tested on Fedora 35: The hercules console:
The log: 12:58:52 HHC01603I quit 12:58:52 HHC01420I Begin Hercules shutdown 12:58:52 HHC01423I Calling termination routines 12:58:52 HHC01423I Calling termination routines 12:58:52 HHC01427I Main storage released 12:58:52 HHC01427I Expanded storage released 12:58:52 HHC01422I Configuration released 12:58:52 HHC00101I Thread id 00007fa000738640, prio 2, name 'rubato_thread' ended 12:58:52 HHC00101I Thread id 00007fa000839640, prio 7, name 'timer_thread' ended 12:58:52 HHC00101I Thread id 00007fa00279e240, prio 5, name 'panel_display' ended The I am curious, and will keep testing for a while. |
I tried it on a freshly updated Fedora 35 and got even stranger results. Running Hercules just bare without a config file, so it comes up and shuts down, I do get the vs: Running with a config file, I don't get the I suspect there are issues in the way Hercules shuts down, because on different systems I get different messages and in different orders. AND... On Ubuntu 21.10, kernel 5.13.0, if I start Hercules with a config file, and just type I have seen this behavior before and spent days trying to narrow it down, booting endless different Linuxes and building with various compilers. All I can say at the moment is the only thing that stands out is Linux 5.13. I saw this hang-on-exit behavior before, but it went away before I could track anything down. I suspect some of these rolling release distributions might have had Linux 5.13 on them for a while and have now moved on. P.S. I updated Kubtuntu 21.10 to kernel 5.16 and it still hangs on exit on that system. Bill |
I've run into similar weirdness. A bunch of lines in the log file never appeared in the console window. FWIW, the Hercules Automatic Operator is being used here. This is on Debian 10. The attached logs Bill |
I've now run into similar issue where some msgs (specifically |
Interesting! Just out of curiosity, is there a sudden flurry of messages preceding the |
Next time it happens I'll grab the log and console output. |
*** MORE INFORMATION *** (for whoever decides to try and tackle this problem) I suspect the problem is somewhere within one or more of the following sections of code: Lines 3314 to 3350 in d0ccfbc
Lines 577 to 619 in d0ccfbc
Lines 228 to 308 in d0ccfbc
panel.c "registers" the panel_cleanup function during startup/initialization (to cause it to be called during shutdown), and shortly thereafter calls set_or_reset_console_mode to set the terminal to "cbreak mode". During shutdown, set_or_reset_console_mode is then called to "undo" what the earlier call did (i.e. restore normal terminal mode).
Additionally, the Notice for example the I suspect one or more of these code points might be where the problem lies. As stated, I'm not a Linux person, so I have no idea whether the above code is sound (sane/correct/proper) or not, so someone else more experienced with how Linux works is going to need to look into this issue. |
Fish, As I still consider myself as a newbie to Hercules development, I thought that I might focus my newbie eyes on this issue rather than just on instruction performance. So I reviewed a few of my Hercules logs. On a Raspberry PI4 (running Armbian Jammy; a Ubuntu version) , I had a MVS TK5 log with multiple duplicate lines, not just the 'Calling termination routines' line. For example,
here is the complete log: 3033-1.log As I was testing a potential fix, I observed missing lines from the console. For example, the console showed (partial output):
but the log showed
17 lines missing starting with '15:23:48 HHC02263I Script 10: processing resumed...'. Both problems seem to be related to the delay timing in do_shutdown_now()_between setting sysblk.shutdown = TRUE; For your consideration regarding this issue, I'll submit a pull request with my 'partial' fix. I'm still missing a few console lines. Jim |
Both Bill and I have confirmed that Jame's PR #634 is good, so I am closing this issue as resolved. |
The current code in
hscmisc.c
at line 1327:shows as:
Changing the code to:
looks better:
I might be wrong of course; you know the code better than I do!
enrico
The text was updated successfully, but these errors were encountered: