Quiet Py3 resource warnings #3279
Merged
+42
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later Pythons (3.6+) enable warnings by default (needed a command line option before then), so some tools give off warnings now. This change quiets the warnings from the gcc, g++ and swig tools. Signed-off-by: Mats Wichmann <[email protected]>
bdbaddog
reviewed
Jan 25, 2019
| @@ -11,6 +11,10 @@ RELEASE VERSION/DATE TO BE FILLED IN LATER | |||
|
|
|||
| - Whatever John Doe did. | |||
|
|
|||
| From Mats Wichmann: | |||
| - Quiet open file ResourceWarnings on Python >= 3.6 caused by | |||
There was a problem hiding this comment.
Instead of "Quiet" how about Resolve?
There was a problem hiding this comment.
I can do that if you want...
|
Looks good. |
|
Waiting for CI. Assuming all good will merge. |
|
I see in https://travis-ci.org/SCons/scons/jobs/484531435 that all but the warnings on |
mwichmann
added a commit
to mwichmann/scons
that referenced
this pull request
Feb 8, 2019
Following on to PR SCons#3279 which cleaned up warnings for gcc, g++ and swig by using context managers, do the same for Windows vc. Signed-off-by: Mats Wichmann <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later Pythons (3.6+) enable warnings by default (needed a command
line option before then), so some tools give off warnings now.
This change quiets the warnings from the gcc, g++ and swig tools.
Signed-off-by: Mats Wichmann [email protected]
Contributor Checklist:
master/src/CHANGES.txtdirectory (and read theREADME.txtin that directory)