Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_external overwritten by AMS interface #169

Open
patrickmelix opened this issue Nov 8, 2024 · 3 comments
Open

load_external overwritten by AMS interface #169

patrickmelix opened this issue Nov 8, 2024 · 3 comments

Comments

@patrickmelix
Copy link
Collaborator

The classmethod load_external is overwritten by the AMS interface without the jobname option. This prevents loading from external calculations where the folder name does not match the job name.

@patrickmelix
Copy link
Collaborator Author

And another detail about this I noticed: With the current setup PLAMS cannot load a standard GUI job. The rkf files are under jobname.results and not in the same directory as for PLAMS. Perhaps we can fix this in one effort.

@mhellstr
Copy link
Contributor

AMSJob.load_external("jobname.results") or AMSJob.load_external("jobname.results/ams.rkf") should both work for jobs run through the GUI. I use it all the time. It should then use "jobname" as the job name.

To set a custom name, you could just assign job.name = "mycustomname" on the next line, or is there some special reason to do it in the constructor?

@patrickmelix
Copy link
Collaborator Author

Ok, that is easier than I imagined 👍 Did not think to test the .results folder...

Special reason was to be able to load jobs from non-PLAMS runs, especially from people not using PLAMS. Workaround is to manually create symlinks, but that is annoying...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants