Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-input): introduce maxlength property #976

Merged
merged 4 commits into from
Nov 26, 2019
Merged

feat(ui5-input): introduce maxlength property #976

merged 4 commits into from
Nov 26, 2019

Conversation

ivoplashkov
Copy link
Member

FIXES: #931

fifoosid
fifoosid suggested changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@fifoosid fifoosid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for this feature

@fifoosid fifoosid merged commit c149f5f into SAP:master Nov 26, 2019
plamenivanov91 pushed a commit to plamenivanov91/ui5-webcomponents that referenced this pull request Nov 27, 2019
@ivoplashkov @plamenivanov91
feat(ui5-input): introduce maxlength property (SAP#976)
891222a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-input: implement new property "maxlength"
2 participants
@ivoplashkov @fifoosid