fix(ui5-table): fix row navigation and focus handling #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
ilhan007
changed the title
ilhan007
force-pushed
the
fix-tabble-navigation
branch
from
cf300c7 to
1d0950b
Compare
ilhan007
changed the title
MapTo0
previously requested changes
Oct 30, 2019
packages/main/src/TableRow.js
Outdated
| @@ -80,6 +107,11 @@ class TableRow extends UI5Element { | |||
| return; | |||
| } | |||
|
|
|||
| this.cells.forEach(cell => { | |||
| cell.removeEventListener("click", this.fnOnCellClick); | |||
There was a problem hiding this comment.
you better fire some event from the cell and rely on bubbling so you can catch it in the Row
packages/main/src/Table.js
Outdated
| @@ -210,6 +210,10 @@ class Table extends UI5Element { | |||
| } | |||
| } | |||
|
|
|||
| onColumnHeaderClick() { | |||
| this.getDomRef().querySelector(`#${this._id}-columnHeader`).focus(); | |||
There was a problem hiding this comment.
i wish we make this part of the item navigation but its fine for now
MapTo0
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #861