Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add form support for ui5-select #565

Merged
merged 4 commits into from
Jun 20, 2019
Merged

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Jun 20, 2019

BREAKING CHANGE: in change event the parameter is renamed from selectedItem to selectedOption

@vladitasev vladitasev changed the title Select form support feat: add form support for ui5-select Jun 20, 2019
@vladitasev vladitasev requested review from MapTo0, fifoosid, ilhan007 and pskelin and removed request for MapTo0 June 20, 2019 09:49
@fifoosid
Copy link
Contributor

Please document the change as breaking change because the parameter of the change event is changed

@vladitasev vladitasev merged commit 89e3508 into master Jun 20, 2019
@vladitasev vladitasev deleted the select-form-support branch June 20, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants