fix(ui5-select): keyboard/selection handling improvement #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
suggested changes
Mar 8, 2021
dobrinyonkov
force-pushed
the
select-focus-improvement
branch
from
3421ec8 to
06de8fb
Compare
nnaydenow
reviewed
Mar 15, 2021
|
Test it locally and it works fine. |
Opening the picker moves the focus to the static area. When then closed the focus returns to the ui5- select. When ui5-select is nested in elements with landmark roles, their accesbility information is read out every time the picker is closed. Component is now refactor so focus never leaves the ui5-select DOM. All navigation and selection (Arrows, Space, Enter, Mouse) is now handled by ui5-select.
dobrinyonkov
force-pushed
the
select-focus-improvement
branch
from
01c9fe5 to
7d86706
Compare
fifoosid
approved these changes
Mar 30, 2021
ilhan007
pushed a commit
that referenced
this pull request
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2806
Fixes: #2846
When we open the picker, the focus goes to the static area (listitems). Closing the picker returns the focus to ui5-select. The problem is that than screen readers read the landmark information of the components above.
Summary of chagnes: