-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatePicker: Missing locale crashes application #2836
Comments
Hey @goodefroi, import '@ui5/webcomponents/dist/Assets';
import '@ui5/webcomponents-fiori/dist/Assets';
import '@ui5/webcomponents-react/dist/Assets'; These assets are now dynamic and loaded when required, so it won't bloat your bundlesize like before when importing them. @vladitasev Any opinions? |
Happening with plain UI5 Web Components as well, so I'll forward this to the UI5 Web Components repo: |
Dear @MarcusNotheis, thank you very much for your help. I really appreciate the quick reaction times of you and your team whenever I submitted an issue in the past. |
@MarcusNotheis That's the right approach, yes. It is also not a workaround as it is necessary for productive usage anyway. The development work case should not crash however, and a change with a warning and a fallback option is in preparation. |
Describe the bug
Expanding a
DatePicker
component causes the app to crash (in development) when the browser is set to a locale that is not provided.Isolated Example
Isolated example on
codesandbox.io
.To Reproduce
Steps to reproduce the behavior:
DatePicker
component.Expected behavior
Yeah, not this. Fall back to
en_US
or some other generic locale.Screenshots
UI5 Web Components for React Information
@ui5/webcomponents
version:1.0.0-rc.12
@ui5/webcomponents-react
version:0.14.0
Operating System:
macOS 11.2.1
Browser:
Chrome 88
The text was updated successfully, but these errors were encountered: