fix(ui5-button): set icon-only attribute (#2567) #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the ui5-button component (#2567)
|
|
vladitasev
reviewed
Feb 17, 2021
packages/main/test/pages/Button.html
Outdated
| @@ -29,7 +29,8 @@ | |||
| </head> | |||
|
|
|||
| <body style="background-color: var(--sapBackgroundColor);"> | |||
| <ui5-button icon="home"><!----><!----></ui5-button> | |||
| <ui5-button icon="home" id="icon-only-comment"><!----><!----></ui5-button> | |||
| <ui5-button icon="text" id="icon-only-blank-text"></ui5-button> | |||
There was a problem hiding this comment.
Shouldn't this example rather be > </ui5-button> (have a single space inside)?
packages/main/src/Button.js
Outdated
| @@ -378,7 +378,10 @@ class Button extends UI5Element { | |||
| } | |||
|
|
|||
| get isIconOnly() { | |||
| return !Array.from(this.childNodes).filter(node => node.nodeType !== Node.COMMENT_NODE).length; | |||
| return !Array.from(this.childNodes).filter(node =>{ | |||
There was a problem hiding this comment.
I think ESLINT will require a space after the => operator here
There was a problem hiding this comment.
Yes, you are right.
changes for ESLINT
ilhan007
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When a ui5-button is created with blank text inside the component, for example
<ui5-button icon="message-information"> </ui5-button>, the attribute "icon-only" isn't set correctly.Solution: Trim the node value when node is type of "TEXT_NODE" and check the length of the trimmed value.
FIXES: #2567