fix(ui5-popup): prevent focus on elements below block layer #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When element inside the popup, which can't get focus is clicked, the focus goes on the body element. Then any element below the block layer can be focused. Solution: Don't let the focus leave the popup. Fixes: #2626
georgimkv
previously approved these changes
Feb 9, 2021
|
you have to resolve the merge conflicts |
ilhan007
previously approved these changes
Feb 9, 2021
…pup_background_elements_focus
Done |
georgimkv
previously approved these changes
Feb 9, 2021
ilhan007
approved these changes
Feb 9, 2021
georgimkv
approved these changes
Feb 10, 2021
ilhan007
pushed a commit
that referenced
this pull request
Mar 1, 2021
Problem: When element inside the popup, which can't get focus is clicked, the focus goes on the body element. Then any element below the block layer can be focused. Solution: Don't let the focus leave the popup. Fixes: #2626
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The body element receives focus when an element inside the popup, which can't get focus (div, span) is clicked.
Then any element below the block layer can be focused.
Solution:
Don't let the focus leave the popup.
Fixes: #2626
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist