Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-multi-combobox): The initial focus is set on the ui5-dialog #2702

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

niyap
Copy link
Contributor

@niyap niyap commented Jan 18, 2021

When ui5-multi-combobox web component is used on mobile phone and the list with the available options is visualised in a dialog, the initial focus on opening should be set to the dialog according to the specification.

Fixes: #2692

@niyap niyap requested a review from MapTo0 January 18, 2021 14:43
Copy link
Member

@MapTo0 MapTo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add _prevent-initial-focus to the RPO when it is open on a phone + prevent_focus_restore

@MapTo0 MapTo0 merged commit aeed733 into SAP:master Jan 22, 2021
kineticjs pushed a commit to kineticjs/ui5-webcomponents that referenced this pull request Jan 25, 2021
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this pull request Feb 1, 2021
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiComboBox not usable on IOS device
2 participants