Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-list): show busy indicator over the list #2684

Merged
merged 1 commit into from
Jan 20, 2021
Merged

fix(ui5-list): show busy indicator over the list #2684

merged 1 commit into from
Jan 20, 2021

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jan 14, 2021 •
edited
Loading

Changes

  • Show busy indicator over the list (as specified in Fiori 3), not at the bottom (as it is prior to this change).
  • Fade background with opacity (0.72), closest to openui5 where we have calculated background - fade(@sapBackgroundColor, 72%)

Technical details

  • introduce new div element ("ui5-list-scroll-container") that is scrollable (overflows), so we can position the busy indicator centrally against the root element, otherwise such positioning with overflow enabled is possible only with position: fixed, which is a bad pattern.

FIXES: #2568

ezgif com-gif-maker

@ilhan007
fix(ui5-list): show busy ind over the list
2a1a40e 
- Show busy over the list (as specified in Fiori 3), not at the bottom.
- Fade background with opacity in openui5 it is calculated fade(@sapBackgroundColor, 72%)

FIXES: #2568
@ilhan007 ilhan007 changed the title fix(ui5-list): show busy ind over the list fix(ui5-list): show busy indicator over the list Jan 14, 2021
@ilhan007 ilhan007 merged commit ad56eaa into master Jan 20, 2021
@ilhan007 ilhan007 deleted the fix-list-busy-row branch January 20, 2021 08:28
ilhan007 added a commit that referenced this pull request Jan 20, 2021
@ilhan007
fix(ui5-list): show busy ind over the list (#2684)
b8b7974 
- Show busy indicator over the list (as specified in Fiori 3), not at the bottom (as it is prior to this change).
- Fade background with opacity (0.72), closest to openui5 where we have calculated background - fade(@sapBackgroundColor, 72%)

FIXES: #2568
@ilhan007 ilhan007 mentioned this pull request Jan 20, 2021
Merged
ilhan007 added a commit that referenced this pull request Jan 21, 2021
@ilhan007
fix(ui5-list): remove busy indicator dom (#2712)
fe76278 
Follow up of #2684 where the placement of the busy has been fixed. With this change we make sure the busy ind DOM is not even rendered when the List is not busy. And, aims to fix the issue with components such as the ComboBox, Select and Input, that uses the List internally, would display additional space after the last list item.
ilhan007 added a commit that referenced this pull request Jan 21, 2021
@ilhan007
fix(ui5-list): remove busy indicator dom (#2712)
90e998c 
Follow up of #2684 where the placement of the busy has been fixed. With this change we make sure the busy ind DOM is not even rendered when the List is not busy. And, aims to fix the issue with components such as the ComboBox, Select and Input, that uses the List internally, would display additional space after the last list item.
kineticjs pushed a commit to kineticjs/ui5-webcomponents that referenced this pull request Jan 25, 2021
@ilhan007 @kineticjs
fix(ui5-list): remove busy indicator dom (SAP#2712)
d247d4a 
Follow up of SAP#2684 where the placement of the busy has been fixed. With this change we make sure the busy ind DOM is not even rendered when the List is not busy. And, aims to fix the issue with components such as the ComboBox, Select and Input, that uses the List internally, would display additional space after the last list item.
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this pull request Feb 1, 2021
@ilhan007 @alexandar-mitsev
fix(ui5-list): show busy ind over the list (SAP#2684)
6cdbca7 
- Show busy indicator over the list (as specified in Fiori 3), not at the bottom (as it is prior to this change).
- Fade background with opacity (0.72), closest to openui5 where we have calculated background - fade(@sapBackgroundColor, 72%)

FIXES: SAP#2568
alexandar-mitsev pushed a commit to alexandar-mitsev/ui5-webcomponents that referenced this pull request Feb 1, 2021
@ilhan007 @alexandar-mitsev
fix(ui5-list): remove busy indicator dom (SAP#2712)
89874cc 
Follow up of SAP#2684 where the placement of the busy has been fixed. With this change we make sure the busy ind DOM is not even rendered when the List is not busy. And, aims to fix the issue with components such as the ComboBox, Select and Input, that uses the List internally, would display additional space after the last list item.
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this pull request Feb 9, 2021
@ilhan007 @NHristov-sap
fix(ui5-list): show busy ind over the list (SAP#2684)
e48262e 
- Show busy indicator over the list (as specified in Fiori 3), not at the bottom (as it is prior to this change).
- Fade background with opacity (0.72), closest to openui5 where we have calculated background - fade(@sapBackgroundColor, 72%)

FIXES: SAP#2568
NHristov-sap pushed a commit to NHristov-sap/ui5-webcomponents that referenced this pull request Feb 9, 2021
@ilhan007 @NHristov-sap
fix(ui5-list): remove busy indicator dom (SAP#2712)
d6f60d8 
Follow up of SAP#2684 where the placement of the busy has been fixed. With this change we make sure the busy ind DOM is not even rendered when the List is not busy. And, aims to fix the issue with components such as the ComboBox, Select and Input, that uses the List internally, would display additional space after the last list item.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

@nnaydenow nnaydenow Awaiting requested review from nnaydenow

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui5-list-busy-row should not display when list busy is false
2 participants
@ilhan007 @vladitasev