Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-li-notification*): full-fill accessibility spec #2578

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Dec 15, 2020

We identified gaps in the accessibility implementation, that this change aims to address as follows:

NotificationListItem

  • More Button: added aria-label="More"
  • Close Button: added aria-label="Close"

NotificationListGroupItem

  • Invisible text reading: added "read" or "unread", based on the "read" property.
  • Root: added aria-expanded="true"/"false", based on the "collapsed" property
  • More Button: added aria-label="More"
  • Close Button: added aria-label="Close All"
  • Toggle Button added title="Collapse Group" ("Expand Group") and aria-label="Collapse Group" ("Expand Group") - based on the "collapsed" property

NotificationListGroupItem

  • new property "read" (previously available in the NotificationListItem only)

Note: I didn't set aria-setsize and aria-posinset, as it's not implemented for none of the list items. And, if needed, this will be implemented in the List/ListItemBase.

@ilhan007 ilhan007 added the ACC label Dec 17, 2020
@ilhan007
Copy link
Member Author

ilhan007 commented Jan 8, 2021

Hello @SAP/ui5-webcomponents-topic-rd can you review this change?

@ilhan007 ilhan007 merged commit 20de5ae into master Jan 8, 2021
@ilhan007 ilhan007 deleted the fix-aria-support branch January 8, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants