Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-calendar): keyboard navigation in the picker grid now works properly #2532

Merged
merged 7 commits into from
Dec 3, 2020

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Dec 1, 2020

Deselecting a date via keyboard, when ui5-calendar selection type is "Multiple",
now doesn't cause keyboard navigation in the grid to stop working.

…lection

Problem description:
Deselecting a date, when ui5-calendar selection type is "Multiple",
now doesn't cause keyboard navigation in the grid to stop working.
ui5-calendar grid, when selection type is "Multiple".
@unazko unazko requested a review from ilhan007 December 1, 2020 08:13
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secure this change with a test if possible

@unazko unazko requested a review from ilhan007 December 3, 2020 08:51
@unazko unazko merged commit 371d12d into SAP:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants