Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-daterange-picker): fix RenderScheduler import #2476

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

MarcusNotheis
Copy link
Collaborator

the previous import was crashing in UI5 Web Components React

Thank you for your contribution! 👏

To get it merged faster, kindly review the checklist below:

Pull Request Checklist

the previous import was crashing in UI5 Web Components React
@ilhan007
Copy link
Member

Hello @MarcusNotheis

can you fix the lint error

/home/travis/build/SAP/ui5-webcomponents/packages/main/src/DateRangePicker.js
6:1 error @ui5/webcomponents-base/dist/RenderScheduler.js import should occur before import of ./generated/templates/DateRangePickerTemplate.lit.js import/order

@ilhan007
Copy link
Member

FYI @unazko

@ilhan007 ilhan007 merged commit 13ff13e into master Nov 19, 2020
@ilhan007 ilhan007 deleted the fix/date-range-picker-render-scheduler branch November 19, 2020 05:57
ilhan007 pushed a commit that referenced this pull request Nov 19, 2020
the previous import was crashing in UI5 Web Components React
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants