fix(ui5-input): cancel suggestion selection with ESC #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifoosid
suggested changes
Oct 5, 2020
packages/main/src/Input.js
Outdated
| @@ -624,6 +638,20 @@ class Input extends UI5Element { | |||
| } | |||
| } | |||
|
|
|||
| _handleEscape() { | |||
| if (this.Suggestions && this.Suggestions._isItemOnTarget()) { | |||
There was a problem hiding this comment.
I think that we should check if this.showSuggestions is set as well
fifoosid
suggested changes
Oct 5, 2020
fifoosid
approved these changes
Oct 5, 2020
ilhan007
added a commit
that referenced
this pull request
Oct 17, 2020
When the users navigates between the items with UP/DOWN, the value is updated and shows the currently previewed item, Now, the user is able to "cancel" this selection by pressing ESC. FIXES: #2254
ilhan007
added a commit
that referenced
this pull request
Nov 11, 2020
When the users navigates between the items with UP/DOWN, the value is updated and shows the currently previewed item, Now, the user is able to "cancel" this selection by pressing ESC. FIXES: #2254
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the users navigates between the items with UP/DOWN, the value is updated and shows the currently previewed item,
Now, the user is able to "cancel" this selection by pressing ESC.
FIXES: #2254