Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List and ListItem accessibility roles should be set to list and listitem if selection mode is None #2231

Closed
mastanshaikk opened this issue Sep 22, 2020 · 3 comments
Assignees

Comments

@mastanshaikk
Copy link

Describe the bug
List and ListItem accessibility roles should be set to "list" and "listitem" if selection mode is None, as listbox and option role combination represents a select/option semantics but not list semantics, as a result the content of ui5-list element are not accessible via screen reader virtual cursor navigation using arrow keys. A role "option" masks all ui5-li or ui5-li-custom except to the first list item element contents from displaying in the screen reader elements list, for NVDA pressing Insert + F7 screen reader elements list can be displayed.
List.js: https://github.com/SAP/ui5-webcomponents/blob/master/packages/main/src/List.js#L197 is there a way to override?
ListItem.js: https://github.com/SAP/ui5-webcomponents/blob/master/packages/main/src/ListItem.js#L297 is there a way to override?

To reproduce
Steps to reproduce the behavior:

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/List/ for a list with selection mode="None" role of listbox and option are applied.

Expected behavior
ui5-list and ui5-li should be have a role of "list" and "listitem" for None selection mode.

Affected components (if known)
StandardListItem, CustomListItem

@fifoosid
Copy link
Contributor

fifoosid commented Sep 23, 2020

Hi @mastanshaikk

As you can see, currently we have provided default values for both properties, which are suitable for all cases. If you need a way to override the custom values, we can provide a way to do so. Please, let me know if overriding the default values would be a solution for your use case.

@mastanshaikk
Copy link
Author

Hi @fifoosid

Yeah, that works, if the default roles can be overridden.

@fifoosid
Copy link
Contributor

Issue is resolved by the PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants