Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework): implement invalidateParent #1964

Merged
merged 4 commits into from
Jul 20, 2020
Merged

Conversation

fifoosid
Copy link
Contributor

No description provided.

Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comments in the code, there is one more thing I can think of: we should revert the variable back go false when a child leaves the parent (otherwise if the user adds the child to another parent, it will continue invalidating the new parent, although it might not have set such metadata).

Probably a good place to do this would be after this._detachChildPropertyUpdated(child); in the same if statement:

children.forEach(child => {
			if (child && child.isUI5Element) {
				this._detachChildPropertyUpdated(child);
			}

			if (isSlot(child)) {
				this._detachSlotChange(child);
			}
		});

docs/dev/Metadata.md Outdated Show resolved Hide resolved
packages/base/src/UI5Element.js Outdated Show resolved Hide resolved
packages/base/src/UI5Element.js Outdated Show resolved Hide resolved
packages/base/src/UI5Element.js Outdated Show resolved Hide resolved
packages/base/src/UI5Element.js Outdated Show resolved Hide resolved
@fifoosid fifoosid merged commit 104abcc into master Jul 20, 2020
@fifoosid fifoosid deleted the invalidate-parent branch July 20, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants