feat(ui5-panel): support aria-label and aria-labelledby #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for **aria-label** and **aria-labelledby** * if **aria-label** or **aria-labelledby** are set externally, **aria-label** is set inside the shadowDOM. * if not, **aria-labelledby** is automatically set to the reference of internal title, when the header-text property is set. * if panel has items in **header** slot these values are propagated to expand/collapse button. In addition: * accessibility attributes are removed from header container when the panel is fixed. * panel could be expanded/collapsed throught expand/collapse button when it has items in **header** slot. #Fixes: 1880
nnaydenow
changed the title
vladitasev
requested changes
Jul 7, 2020
vladitasev
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for aria-label and aria-labelledby
In addition:
#1880