Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-tabcontainer): aria-controls now points to an existing ID #1817

Merged
merged 2 commits into from
Jun 16, 2020
Merged

fix(ui5-tabcontainer): aria-controls now points to an existing ID #1817

merged 2 commits into from
Jun 16, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Jun 16, 2020 •
edited
Loading

There was a typo in the template: _position should have been _posinset.

closes: #1808

@vladitasev vladitasev merged commit 4bd3604 into master Jun 16, 2020
@vladitasev vladitasev deleted the fix-tab-container-aria-controls branch June 16, 2020 12:22
vladitasev added a commit that referenced this pull request Jun 16, 2020
@vladitasev
fix(ui5-tabcontainer): aria-controls now points to an existing ID (#1817
2c61f50 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

@fifoosid fifoosid Awaiting requested review from fifoosid

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-tabcontainer] Component A11 issue(Invalid ARIA attribute value: aria-controls="ui5-tc-contentItem-1")
2 participants
@vladitasev @ilhan007